Vote #81894
未完了Mentions not working if status is changed
0%
説明
In Redmine 5.0 the new Mentions feature is not working, if the status of the ticket is changed.
It seems there is an error caused by reassigning a variable:
!image.png!
//Steps to reproduce:
- Edit Ticket
- @Mentions works
- Change Status to other state
- @Mentions not working and the obove error is shown in dev tools
journals
--------------------------------------------------------------------------------
The same happens with attachments.
Steps
# Edit ticket
# Select a file to attach
The file appears at Files section
# Change issue status to other state
Right after the status change, the file listed at Files section, is removed, and the error above is printed on browser console.
--------------------------------------------------------------------------------
Is there a patch ready for this ?
--------------------------------------------------------------------------------
Thanks for reporting this!
Can you test the following patch?
<pre><code class="patch">
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
index 1dfa26cb2..031273d44 100644
--- a/app/helpers/application_helper.rb
+++ b/app/helpers/application_helper.rb
@@ -1831,9 +1831,7 @@ module ApplicationHelper
def update_data_sources_for_auto_complete(data_sources)
javascript_tag(
- "const currentDataSources = rm.AutoComplete.dataSources;" \
- "const newDataSources = JSON.parse('#{data_sources.to_json}'); " \
- "rm.AutoComplete.dataSources = Object.assign(currentDataSources, newDataSources);"
+ "rm.AutoComplete.dataSources = Object.assign(rm.AutoComplete.dataSources, JSON.parse('#{data_sources.to_json}'));"
)
end
</code></pre>
This patch fixes only the console error.
--------------------------------------------------------------------------------
Fernando Hartmann wrote:
> The same happens with attachments.
> Steps
> # Edit ticket
> # Select a file to attach
> The file appears at Files section
> # Change issue status to other state
>
> Right after the status change, the file listed at Files section, is removed, and the error above is printed on browser console.
This is a different error and it's generated by the change from #34641. Until a proper fix is ready, you can try reverting the changes from @app/views/issues/edit.js.erb@ and @app/views/issues/edit.js.erb@.
--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
Created a new issue (#37053) for the second issue.
--------------------------------------------------------------------------------
Marius BALTEANU wrote:
> Thanks for reporting this!
>
> Can you test the following patch?
> [...]
>
> This patch fixes only the console error.
worked for me with same issue. thank you
--------------------------------------------------------------------------------
related_issues
copied_to,Confirmed,37053,Attachments are lost when the status of the ticket is changed