プロジェクト

全般

プロフィール

Vote #63522

完了

Associated revisions are displayed in wrong order for Git, Mercurial (SHA-1 DVCSs)

Admin Redmine さんがほぼ2年前に追加. ほぼ2年前に更新.

ステータス:
Closed
優先度:
通常
担当者:
-
カテゴリ:
SCM_3
対象バージョン:
開始日:
2008/06/29
期日:
進捗率:

0%

予定工数:
category_id:
3
version_id:
2
issue_org_id:
1546
author_id:
1433
assigned_to_id:
0
comments:
3
status_id:
5
tracker_id:
3
plus1:
0
affected_version:
closed_on:
affected_version_id:
ステータス-->[Closed]

説明

Associated revisions are currently sorted by revision name, in ascending order. (@source:trunk/app/models/issue.rb@1594#L31@) However, certain SCMs don't use sequential numeric values (for instance: Git, Mercurial and Monotone use SHA-1 hashes), and the commits appear possibly in the wrong order for them.

This trivial patch tries to order first by the @committed_on@ field, leaving the @revision@ as a secondary sorting column.


journals

You're right. This sort order wasn't updated when the revision field was changed from numeric to string.
Fixed in r1596.

has_and_belongs_to_many :changesets, :order => "#{Changeset.table_name}.committed_on ASC, #{Changeset.table_name}.id ASC"
--------------------------------------------------------------------------------
> has_and_belongs_to_many :changesets, :order => "#{Changeset.table_name}.committed_on ASC, #{Changeset.table_name}.id ASC"

can I suggest this would be nicer (or at least optional) to be DESC rather than ASC so the latest revision is the topmost, as per activity and most other lists throughout the interface? that's how I've set it in mine.

--------------------------------------------------------------------------------
Changed in r2519. Changsets are now sorted in the same order as the comments (which is based on a user preference).
--------------------------------------------------------------------------------

Admin Redmine さんがほぼ2年前に更新

  • カテゴリSCM_3 にセット
  • 対象バージョン0.8_2 にセット

他の形式にエクスポート: Atom PDF

いいね!0
いいね!0